Reset I2S peripheral for analog microphone. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove additional delay to avoid an indeterminate state.
Better option solving the problem as we reset entire I2S peripheral, may which it may be in an indeterminate state after a soft reset, in which the analog microphone does not work.
Add an required includes
|
Please squash three commits |
1 task
|
Thanks for your contribution, and for the research + testing. I will come back to this PR in the next few days. Would it be OK if I make a few "maintainer edits" in your repo branch before merging? Basically I think the reset code should be moved into a separate method, so we can later make this optional and add settings to enable your hard reset code. |
|
Great, it will be even better, I agree to a separate method and including it in the config. Please do it. |
|
is this still alive/required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the analog microphone problem as we reset entire I2S peripheral, may which it may be in an indeterminate state after a soft reset, in which the microphone does not work.
This variant of peripheral reset, using the register write sequence as in the bootloader_random_disable function of the esp-idf bootloader_support component, gave excellent results after many hours of testing with a cyclic soft reset.